Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix:failoverbug and retries change to string type #195

Merged
merged 5 commits into from
Sep 9, 2019
Merged

Fix:failoverbug and retries change to string type #195

merged 5 commits into from
Sep 9, 2019

Conversation

hxmhlt
Copy link
Contributor

@hxmhlt hxmhlt commented Sep 6, 2019 •
edited
Loading

What this PR does:
Fix:failoverbug and retries change to string type
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@hxmhlt hxmhlt changed the title Fix:failoverbug and reties change to string type Fix:failoverbug and retries change to string type Sep 6, 2019
@codecov-io
Copy link

codecov-io commented Sep 6, 2019 •
edited
Loading

Codecov Report

Merging #195 into develop will decrease coverage by 0.05%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #195      +/-   ##
===========================================
- Coverage    67.82%   67.76%   -0.06%     
===========================================
  Files           94       94              
  Lines         5862     5870       +8     
===========================================
+ Hits          3976     3978       +2     
- Misses        1474     1482       +8     
+ Partials       412      410       -2
Impacted Files Coverage Δ
config/method_config.go 60% <ø> (ø) ⬆️
config/reference_config.go 82.75% <100%> (ø) ⬆️
config/service_config.go 65.82% <100%> (ø) ⬆️
cluster/cluster_impl/failback_cluster_invoker.go 78.49% <50%> (-0.63%) ⬇️
cluster/cluster_impl/failover_cluster_invoker.go 79.06% <62.5%> (-5.55%) ⬇️
config/base_config.go 60.81% <0%> (-2.71%) ⬇️
cluster/loadbalance/least_active.go 91.3% <0%> (ø) ⬆️
config_center/configuration_parser.go 50% <0%> (ø) ⬆️
filter/impl/active_filter.go 18.18% <0%> (ø) ⬆️
protocol/dubbo/pool.go 73.6% <0%> (+0.27%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7636e96...ead43d6. Read the comment docs.

@pantianying
Copy link
Member

LGTM

@fangyincheng
Copy link
Contributor

Modify config.yml of config/testdata/ pls.

@AlexStocks
Copy link
Contributor

LGTM

@hxmhlt
Copy link
Contributor Author

hxmhlt commented Sep 7, 2019

Modify config.yml of config/testdata/ pls.

done

fangyincheng
fangyincheng approved these changes Sep 8, 2019
View reviewed changes
Copy link
Contributor

@fangyincheng fangyincheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexStocks AlexStocks merged commit 359bdab into apache:develop Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexStocks AlexStocks AlexStocks left review comments

@fangyincheng fangyincheng fangyincheng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hxmhlt @codecov-io @pantianying @fangyincheng @AlexStocks